Add important files for container build to rebuild check #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we did rebuild check we just looked if dockerfile and files in that directory has changed. However, these are not the only ones giving us dependencies for container image build. Check also: * spec file * script file used during the build
|
/kickstart-test --testtype smoke |
poncovka
approved these changes
Jan 26, 2021
VladimirSlavik
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we did rebuild check we just looked if dockerfile and files in that directory has changed. However, these are not the only ones giving us dependencies for container image build.
Check also:
This PR should prevent issue similar to what happened with
nosedependency removal.Tested by owners PR, contributors spec change, contributors scripts change, contributors dockerfile change.